Skip to content

ref(node): Add sentry.parent_span_already_sent attribute #16870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 10, 2025

This adds a new attribute to spans that we send from the Node SDK because their parent span was already sent. This can be used by us or customers to debug why certain things show up as transactions/root spans in product. We could possibly also use this in the trace view to give users helpful pointers.

@mydea mydea requested review from Lms24, AbhiPrasad and s1gr1d July 10, 2025 06:29
@mydea mydea self-assigned this Jul 10, 2025
@mydea mydea changed the title ref(node): Add sentry.transaction.parent_span_already_sent attribute ref(node): Add sentry.parent_span_already_sent attribute Jul 10, 2025
Copy link
Contributor

github-actions bot commented Jul 10, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.81 kB - -
@sentry/browser - with treeshaking flags 22.53 kB - -
@sentry/browser (incl. Tracing) 39.66 kB - -
@sentry/browser (incl. Tracing, Replay) 77.79 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.73 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 82.49 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 94.61 kB - -
@sentry/browser (incl. Feedback) 40.48 kB - -
@sentry/browser (incl. sendFeedback) 28.49 kB - -
@sentry/browser (incl. FeedbackAsync) 33.38 kB - -
@sentry/react 25.58 kB - -
@sentry/react (incl. Tracing) 41.64 kB - -
@sentry/vue 28.26 kB - -
@sentry/vue (incl. Tracing) 41.46 kB - -
@sentry/svelte 23.83 kB - -
CDN Bundle 25.36 kB - -
CDN Bundle (incl. Tracing) 39.63 kB - -
CDN Bundle (incl. Tracing, Replay) 75.57 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 81.02 kB - -
CDN Bundle - uncompressed 74.08 kB - -
CDN Bundle (incl. Tracing) - uncompressed 117.69 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.61 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 244.42 kB - -
@sentry/nextjs (client) 43.28 kB - -
@sentry/sveltekit (client) 40.11 kB - -
@sentry/node 167.89 kB +0.03% +36 B 🔺
@sentry/node - without tracing 100.62 kB +0.03% +30 B 🔺
@sentry/aws-serverless 128.72 kB +0.03% +31 B 🔺

View base workflow run

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% happy with the behaviour overall but adding the attribute for diagnosis is a good idea!

@mydea mydea merged commit fa210ad into develop Jul 15, 2025
167 checks passed
@mydea mydea deleted the fn/opt-out-orphaned-spans branch July 15, 2025 09:35
msonnb pushed a commit that referenced this pull request Jul 15, 2025
This adds a new attribute to spans that we send from the Node SDK
because their parent span was already sent. This can be used by us or
customers to debug why certain things show up as transactions/root spans
in product. We could possibly also use this in the trace view to give
users helpful pointers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants