-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nextjs): Client-side parameterized routes #16934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brice Friha <[email protected]>
size-limit report 📦
|
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
AbhiPrasad
reviewed
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see maybeParameterizeRoute
be split up.
export const maybeParameterizeRoute = (route: string): string | undefined {
// caches manifest (and handles edge cases where global isn't defined)
const manifest = getManifest();
if (!manifest) {
return undefined;
}
const { staticRoutes, dynamicRoutes } = manifest;
if (!Array.isArray(staticRoutes) || !Array.isArray(dynamicRoutes)) {
return undefined;
}
const matches = findMatchingRoutes(route, staticRoutes, dynamicRoutes);
// We can always do the `sort()` call, it will short-circuit when it has one array item
// might make sense to also cache `getRouteSpecificity` results
return matches.sort((a, b) => getRouteSpecificity(a) - getRouteSpecificity(b))[0];
}
function findMatchingRoutes(route: string, staticRoutes: string[], dynamicRoutes: string[]): string[] {
const matches: string[] = [];
// first do short-circuit operations with staticRoutes
// then test on regex with dynamicRoutes
// maybe we can filter dynamicRoutes before we run regex? To get rid of
// dynamicRoutes that will definitely never match?
}
@AbhiPrasad I did some cursor ping pong and went down the route of caching manifest, route matches and regexes instead of pre-filtering as this would have been failure-prone with catchall routes |
AbhiPrasad
approved these changes
Jul 14, 2025
msonnb
pushed a commit
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16683
Implements the app-router parameterization by leveraging the injected manifest within our existing app-router instrumentation.
I just added the same tests for every Next.js e2e-test version + turbopack