fix(node): Fix exports for openai instrumentation #17238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
reviewed
Jul 31, 2025
I tested this with different scenarios locally, and it should work fine. I don't think adding a test for the exports is necessary here, since it should behave as expected—OpenAI just happens to export both a default and a named constant for the same constructor 😅 |
chargome
approved these changes
Jul 31, 2025
RulaKhaled
deleted the
rolaabuhasna/js-791-sentrynode-v940-breaks-openai-imports-when-tracessampler-is
branch
RulaKhaled
added a commit
that referenced
this pull request
Jul 31, 2025
Fixed an issue where default exports in CommonJS were failing. Returning a new exports object was overriding some default export functionality. I removed some redundant code as well.
RulaKhaled
added a commit
that referenced
this pull request
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where default exports in CommonJS were failing. Returning a new exports object was overriding some default export functionality. I removed some redundant code as well.