Skip to content

fix(angular): If no other information is provided, fallback the request itself. #17293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(angular): If no other information is provided, fallback the request itself. #17293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/angular/src/errorhandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ function extractHttpModuleError(error: HttpErrorResponse): string | Error {
return `Server returned code ${error.status} with body "${error.error}"`;
}

// If we don't have any detailed information, fallback to the request message itself.
return error.message;
// If we don't have any detailed information, fallback to the request itself.
return error;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Return Types Cause Runtime Errors

The function now returns inconsistent types: while other branches return formatted strings, the fallback case returns the entire error object instead of a string. This type inconsistency could cause runtime errors or unexpected behavior in calling code that expects a string.

Fix in Cursor Fix in Web

}

type ErrorCandidate = {
Expand Down