-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(feedback): Remove almost duplicate sendFeedback
rejection message
#17297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fair to me to remove. Wondering if there was an intention behind the special casing for response.statusCode
being 0
but given there's no user-facing difference to the callback, this might just have been an oversight.
Yeah I had the same thought, but this should be an equivalent solution at least I suppose! |
sendFeedback
rejection messagesendFeedback
rejection message
Noticed this by chance, this is a redundant message (we also use this as general fallback anyhow).
The two messages have been:
Which are virtually identical. We can safe some bytes there IMHO.