Add --sentry-trace CLI option#976
Draft
stayallive wants to merge 2 commits into
Draft
Conversation
stayallive
marked this pull request as ready for review
January 28, 2025 12:44
stayallive
marked this pull request as draft
January 28, 2025 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--sentry-traceglobal CLI option. Every Artisan command can be triggered with this option and the Sentry SDK will wrap its execution in a transaction.In addition to this, scheduled commands that are being ran in the background will get
--sentry-traceapplied by default so they are always traced.This basically reverts #975 with extra steps 😅
Edit: As it turns out, adding parameters to the command string modifies the mutex, but since we add it only when it's being run the mutex is not always consistent resulting in commands just running once... needs some more adjustments! To be clear, the CLI option works great, adding it like we do to the scheduled command doesn't.