-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3] Move the Misc group over to the tox gen script #3982
Conversation
How often does the Tox script run, @sentrivana? Could this end up being a problem? Also, right now the latest tests, I believe, are not required for CI to pass. Which I think is good, because if a change in a new version of an integration breaks the SDK, this is not a regression in the SDK, and so we should not be blocked from making other PRs until it is fixed. This Tox script basically now makes it a requirement for the latest tests to pass, right? If yes, have we considered the consequences of this and thought of any alternative solutions, e.g. only adding the tests for latest versions if they pass? |
Co-authored-by: Daniel Szoke <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3982 +/- ##
=======================================
Coverage 80.32% 80.32%
=======================================
Files 140 140
Lines 15510 15510
Branches 2628 2628
=======================================
Hits 12458 12458
Misses 2209 2209
Partials 843 843
|
@szokeasaurusrex That's correct, My plan would be to have the script run automatically every week (the freq can be tweaked anytime) in a GitHub action, which would ideally then also create a PR with the changed So in general, the only point in time the contents of Wdyt? |
@sentrivana i guess if it is nonblocking and if we update the tox.ini often, this should be okay. Running the script every week might even be overkill but we can always tweak I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR appears to remove tests for trytond
version 4. Is this intentional?
Good catch. Looks like trytond 4 is the first victim of the new 5 year cutoff period. I'll add it to the script's ignore list for now and let's properly remove it in #4045 |
"strawberry": { | ||
"package": "strawberry-graphql[fastapi,flask]", | ||
"deps": { | ||
"*": ["httpx"], | ||
}, | ||
}, | ||
"trytond": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm keeping the config around even if the script is not generating stuff for trytond atm. Once we enable it, it should just work out of the box.
loguru
,trytond
, andtyper
from the tox templatepopulate_tox.py
populate_tox.py
to fill in entries for themsplit_gh_tox_actions.py
to generate the CI yaml files so that they correspond to the newtox.ini
Note that this effectively eliminates the
-latest
tests for the Misc group. The script doesn't generate any-latest
tests since it always makes sure to add a pinned entry for the latest version. So in case all of the integrations in a single group are using the script, the whole-latest
test category is removed.