Skip to content

fix: Rename op db to db.query #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: potel-base
Choose a base branch
from
Open

fix: Rename op db to db.query #4444

wants to merge 5 commits into from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jun 5, 2025

  • According to our span ops there is no op called just db, but we're emitting these from django, clickhouse, asyncpg and pymongo. Changing to db.query instead.
  • There was also a breadcrumb with type db that's also officially not a supported type, changed it to query.

This is intentionally just on potel-base since it's technically a breaking change.

Copy link

codecov bot commented Jun 5, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
20543 1 20542 4355
View the top 1 failed test(s) by shortest run time
tests.integrations.logging.test_logging::test_logging_captured_warnings
Stack Traces | 0.043s run time
.../integrations/logging/test_logging.py:259: in test_logging_captured_warnings
    assert len(recwarn) == 1
E   assert 2 == 1
E    +  where 2 = len(WarningsRecorder(record=True))

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana marked this pull request as ready for review June 5, 2025 07:52
@sentrivana sentrivana requested a review from a team as a code owner June 5, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants