feat(loguru): Sentry logs for Loguru #4445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4445 +/- ##
==========================================
- Coverage 80.68% 80.55% -0.13%
==========================================
Files 142 142
Lines 15986 16025 +39
Branches 2732 2745 +13
==========================================
+ Hits 12898 12909 +11
- Misses 2230 2245 +15
- Partials 858 871 +13
|
sentrivana
commented
Jun 6, 2025
| @@ -283,3 +286,197 @@ def test_logging_dictionary_args(sentry_init, capture_events): | |||
| == "the value of foo is bar, and the value of bar is baz" | |||
| ) | |||
| assert event["logentry"]["params"] == {"foo": "bar", "bar": "baz"} | |||
|
|
|||
|
|
|||
| def test_sentry_logs_warning(sentry_init, capture_envelopes): | |||
There was a problem hiding this comment.
These were just moved to this file from tests/test_logs.py
|
Additional change: removed setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to send Loguru logs to Sentry.
We can't parametrize them nicely, but this is a good first step.
Also:
@minimum_python_37from some tests that don't need 3.7+._LoguruBaseHandler)Closes #4151