feat(feedback): Save form state for un-submitted data #4538
+90
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2025
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9402883 | 448.53 ms | 468.73 ms | 20.20 ms |
| e42816c | 401.30 ms | 410.04 ms | 8.74 ms |
| 3e4cdf5 | 462.35 ms | 474.96 ms | 12.61 ms |
| 77e88fc | 478.48 ms | 487.21 ms | 8.73 ms |
| 8cb898b | 438.83 ms | 420.58 ms | -18.25 ms |
| 2646c98 | 429.98 ms | 421.63 ms | -8.35 ms |
| 6b1624f | 462.78 ms | 465.13 ms | 2.35 ms |
| df05370 | 477.62 ms | 491.63 ms | 14.00 ms |
| e5d5735 | 452.70 ms | 453.04 ms | 0.34 ms |
| 894ebb0 | 497.45 ms | 545.04 ms | 47.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9402883 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| e42816c | 17.75 MiB | 20.12 MiB | 2.38 MiB |
| 3e4cdf5 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 77e88fc | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 8cb898b | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 2646c98 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 6b1624f | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| df05370 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| e5d5735 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 894ebb0 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
Previous results on branch: antonis/feedback-save-state
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dc1853f | 328.31 ms | 315.40 ms | -12.92 ms |
| f882e54 | 405.38 ms | 419.92 ms | 14.54 ms |
| b2e7638 | 386.83 ms | 431.30 ms | 44.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dc1853f | 17.75 MiB | 20.12 MiB | 2.38 MiB |
| f882e54 | 17.75 MiB | 20.12 MiB | 2.38 MiB |
| b2e7638 | 17.75 MiB | 20.12 MiB | 2.38 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e42816c+dirty | 347.06 ms | 348.18 ms | 1.12 ms |
| 269c976+dirty | 395.13 ms | 438.37 ms | 43.24 ms |
| 2646c98+dirty | 415.13 ms | 438.41 ms | 23.28 ms |
| d1a10a1+dirty | 364.43 ms | 362.98 ms | -1.45 ms |
| 3e4cdf5+dirty | 642.13 ms | 702.23 ms | 60.10 ms |
| 6b1624f+dirty | 382.17 ms | 441.00 ms | 58.83 ms |
| 0325426+dirty | 418.89 ms | 485.00 ms | 66.11 ms |
| 894ebb0+dirty | 417.81 ms | 499.74 ms | 81.93 ms |
| 9402883+dirty | 436.49 ms | 518.94 ms | 82.45 ms |
| e5d5735+dirty | 377.37 ms | 430.04 ms | 52.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e42816c+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| 269c976+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 2646c98+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| d1a10a1+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| 3e4cdf5+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 6b1624f+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 0325426+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 894ebb0+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 9402883+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| e5d5735+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
Previous results on branch: antonis/feedback-save-state
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dc1853f+dirty | 385.76 ms | 398.98 ms | 13.22 ms |
| b2e7638+dirty | 391.75 ms | 393.87 ms | 2.12 ms |
| f882e54+dirty | 401.84 ms | 406.18 ms | 4.34 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dc1853f+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| b2e7638+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| f882e54+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5d5735+dirty | 1222.02 ms | 1222.22 ms | 0.20 ms |
| 8cb898b+dirty | 1221.40 ms | 1231.78 ms | 10.37 ms |
| 77e88fc+dirty | 1224.55 ms | 1232.41 ms | 7.86 ms |
| 9402883+dirty | 1219.65 ms | 1217.94 ms | -1.72 ms |
| 894ebb0+dirty | 1224.33 ms | 1214.45 ms | -9.89 ms |
| e42816c+dirty | 1211.29 ms | 1219.65 ms | 8.37 ms |
| 0325426+dirty | 1228.88 ms | 1229.92 ms | 1.04 ms |
| 0459aee+dirty | 1232.82 ms | 1231.19 ms | -1.63 ms |
| 6b1624f+dirty | 1224.65 ms | 1225.65 ms | 1.00 ms |
| 269c976+dirty | 1210.02 ms | 1204.46 ms | -5.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5d5735+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 8cb898b+dirty | 2.63 MiB | 3.71 MiB | 1.08 MiB |
| 77e88fc+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 9402883+dirty | 2.63 MiB | 3.71 MiB | 1.07 MiB |
| 894ebb0+dirty | 2.63 MiB | 3.71 MiB | 1.07 MiB |
| e42816c+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 0325426+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 0459aee+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 6b1624f+dirty | 2.63 MiB | 3.71 MiB | 1.07 MiB |
| 269c976+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
Previous results on branch: antonis/feedback-save-state
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dc1853f+dirty | 1223.29 ms | 1225.67 ms | 2.38 ms |
| b2e7638+dirty | 1238.18 ms | 1232.37 ms | -5.82 ms |
| f882e54+dirty | 1216.66 ms | 1220.32 ms | 3.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dc1853f+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| b2e7638+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| f882e54+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5d5735+dirty | 1217.78 ms | 1221.80 ms | 4.02 ms |
| 8cb898b+dirty | 1209.39 ms | 1207.57 ms | -1.82 ms |
| 77e88fc+dirty | 1218.79 ms | 1220.00 ms | 1.21 ms |
| 9402883+dirty | 1217.71 ms | 1213.02 ms | -4.69 ms |
| 894ebb0+dirty | 1210.94 ms | 1202.08 ms | -8.85 ms |
| e42816c+dirty | 1220.08 ms | 1222.46 ms | 2.38 ms |
| 0325426+dirty | 1210.17 ms | 1216.37 ms | 6.20 ms |
| 0459aee+dirty | 1233.67 ms | 1239.80 ms | 6.12 ms |
| 6b1624f+dirty | 1224.12 ms | 1220.73 ms | -3.39 ms |
| 269c976+dirty | 1223.29 ms | 1222.90 ms | -0.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5d5735+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| 8cb898b+dirty | 3.19 MiB | 4.28 MiB | 1.09 MiB |
| 77e88fc+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 9402883+dirty | 3.19 MiB | 4.27 MiB | 1.09 MiB |
| 894ebb0+dirty | 3.19 MiB | 4.27 MiB | 1.09 MiB |
| e42816c+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 0325426+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| 0459aee+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| 6b1624f+dirty | 3.19 MiB | 4.27 MiB | 1.09 MiB |
| 269c976+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
Previous results on branch: antonis/feedback-save-state
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dc1853f+dirty | 1216.92 ms | 1226.45 ms | 9.53 ms |
| b2e7638+dirty | 1227.94 ms | 1231.88 ms | 3.94 ms |
| f882e54+dirty | 1211.24 ms | 1205.44 ms | -5.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dc1853f+dirty | 3.19 MiB | 4.32 MiB | 1.14 MiB |
| b2e7638+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| f882e54+dirty | 3.19 MiB | 4.32 MiB | 1.14 MiB |
10 tasks
antonis
changed the title
|
# Conflicts: # packages/core/src/js/feedback/FeedbackWidget.tsx
krystofwoldrich
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Saves form content when closed, failed (reopening the form keeps the content), only clear after sent
💡 Motivation and Context
See #4302
💚 How did you test it?
Manual, CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog