ref(feedback): Extracts FeedbackWidgetProvider in a separate file #4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Krystof Woldrich <[email protected]>
…clicdep # Conflicts: # packages/core/src/js/feedback/FeedbackWidgetManager.tsx
krystofwoldrich
approved these changes
Apr 7, 2025
10 tasks
# Conflicts: # CHANGELOG.md # packages/core/src/js/feedback/FeedbackButton.tsx # packages/core/src/js/feedback/FeedbackWidget.styles.ts # packages/core/src/js/feedback/FeedbackWidgetManager.tsx # packages/core/src/js/feedback/integration.ts # packages/core/test/feedback/FeedbackButton.test.tsx # packages/core/test/feedback/FeedbackWidgetManager.test.tsx # packages/core/test/feedback/__snapshots__/FeedbackButton.test.tsx.snap
|
👍 Looks good. Thank you for fixing the circular deps. |
…clicdep # Conflicts: # packages/core/src/js/feedback/FeedbackWidgetManager.tsx
This was referenced Apr 9, 2025
# Conflicts: # packages/core/src/js/feedback/FeedbackWidget.tsx # packages/core/src/js/feedback/FeedbackWidgetManager.tsx # packages/core/src/js/feedback/ScreenshotButton.tsx # packages/core/test/feedback/ScreenshotButton.test.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Based on feat(feedback): Screenshot button
PR Chain:
📜 Description
Extracts FeedbackWidgetProvider in a separate file (as it should have been).
💡 Motivation and Context
Breaking cyclic dependencies introduced in previous PRs in the chain:
💚 How did you test it?
Manual, CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog