ci: Revert CI runners from Cirrus Labs back to GitHub-hosted - #6032
ci: Revert CI runners from Cirrus Labs back to GitHub-hosted#6032antonis wants to merge 8 commits into
2 issues
code-review: Found 2 issues (1 medium, 1 low)
Medium
IOS_DEVICE bumped to 'iPhone 17' while IOS_VERSION remains '>=18.0' - `.github/workflows/sample-application.yml:22`
The default simulator device was changed from 'iPhone 16' to 'iPhone 17' as part of a PR whose stated scope is reverting runner labels only. The 'iPhone 17' simulator is only available with Xcode 26 / iOS 26 runtimes, but IOS_VERSION still allows iOS >=18.0. If the macos-26 runner image does not ship the iPhone 17 simulator (or an iOS 18.x runtime paired with it), simulator selection in downstream e2e/test steps will fail, breaking the sample-application workflow. This also appears to be an unintended side effect outside the PR's documented scope.
Low
Typo in comment: 'if thedriver' missing space - `dev-packages/e2e-tests/cli.mjs:330`
The updated comment reads 'can fail if thedriver isn't fully connected' — the words 'the' and 'driver' are run together. While this is only a comment and has no runtime impact, it should be corrected for readability.
Duration: 1m 26s · Tokens: 231.9k in / 984 out · Cost: $1.17 (+merge: $0.00)
Annotations
Check warning on line 22 in .github/workflows/sample-application.yml
sentry-warden / warden: code-review
IOS_DEVICE bumped to 'iPhone 17' while IOS_VERSION remains '>=18.0'
The default simulator device was changed from 'iPhone 16' to 'iPhone 17' as part of a PR whose stated scope is reverting runner labels only. The 'iPhone 17' simulator is only available with Xcode 26 / iOS 26 runtimes, but IOS_VERSION still allows iOS >=18.0. If the macos-26 runner image does not ship the iPhone 17 simulator (or an iOS 18.x runtime paired with it), simulator selection in downstream e2e/test steps will fail, breaking the sample-application workflow. This also appears to be an unintended side effect outside the PR's documented scope.