Skip to content

fix(e2e): Remove flaky iOS replay assertion from captureReplay test #6072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 7 commits into from
May 4, 2026
Merged

fix(e2e): Remove flaky iOS replay assertion from captureReplay test #6072

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ebaf461
fix(e2e): Wait for native replay buffer before capturing exception
antonis Apr 29, 2026
0a22be5
Merge branch 'main' into fix/e2e-replay-buffer-timing
antonis Apr 30, 2026
9fc5548
fix(e2e): Retry replay_id check in e2e replay assertion
antonis Apr 30, 2026
8a43b4b
fix(e2e): Remove flaky iOS replay assertion from captureReplay test
antonis Apr 30, 2026
4585880
fix(e2e): Remove flaky iOS replay assertion from captureReplay test
antonis Apr 30, 2026
e411873
Merge branch 'main' into fix/e2e-replay-buffer-timing
antonis Apr 30, 2026
3b1117a
Merge branch 'main' into fix/e2e-replay-buffer-timing
antonis May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions dev-packages/e2e-tests/maestro/captureReplay.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
- runFlow:
file: utils/launchTestAppClear.yml
env:
replaysOnErrorSampleRate: 1.0
- tapOn: "Capture Exception"
- runFlow: utils/assertEventIdVisible.yml

Check warning on line 9 in dev-packages/e2e-tests/maestro/captureReplay.yml

View check run for this annotation

@sentry/warden / warden: code-review

iOS replay e2e assertion removed instead of made tolerant, eliminating coverage 

The hunk deletes the iOS-conditional `runFlow: utils/assertReplay.yml` block, which was the only e2e check that the native iOS replay buffer produced a replay (asserting replayId, replayDuration, replaySegments, and the ftypmp42 codec). The PR description states the fix adds a retry loop around replay_id extraction in sentryApi.js, but sentryApi.js still throws immediately when replay_id is missing (line 72), and the assertion is no longer invoked at all. The net effect is a loss of iOS replay coverage rather than a flakiness fix, so future regressions in the iOS native replay integration will go undetected.
Comment thread
antonis marked this conversation as resolved.
- runFlow:
file: utils/assertReplay.yml
when:
platform: iOS
Loading