fix(logs): update withoutLoggingSupport to remove platforms which support logs #102398
Conversation
github-actions
bot
added
the
Scope: Frontend
|
I'm not sure if we also need to relocate these to the sentry/static/app/data/platformCategories.tsx Line 301 in 7bdb823 |
|
changing to draft because Unity is releasing logs soon™️ , so we can remove that one as well |
JoshuaMoelans
force-pushed
the
joshua/fix/update_logging_support
branch
from
8aefe09 to
348af29
Compare
| 'elixir', | ||
| 'dotnet', | ||
| 'php-symfony', | ||
| 'unity', |
There was a problem hiding this comment.
based on our official docs, we don't yet have logs for unity. Are we planning to add that?
There was a problem hiding this comment.
Yeah the docs will come with the 'full' release in Unity 4.0.0 (they were already moved out of experimental in the beta)
| 'cocoa-swift', | ||
| 'elixir', | ||
| 'dotnet', | ||
| 'php-symfony', |
There was a problem hiding this comment.
do we want to add the 'logs' checkbox for php-symfony and maybe other platforms too? maybe in a follow-up?
JoshuaMoelans
force-pushed
the
joshua/fix/update_logging_support
branch
from
348af29 to
71a4e9a
Compare
JoshuaMoelans
force-pushed
the
joshua/fix/update_logging_support
branch
from
71a4e9a to
500b8af
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| ]); | ||
|
|
||
| // List of platforms that do not have logging support. We make use of this list in the product to not provide any Logging | ||
| export const withoutLoggingSupport: Set<PlatformKey> = new Set([ | ||
| 'cocoa-objc', | ||
| 'cocoa-swift', | ||
| 'elixir', | ||
| 'dotnet', | ||
| 'php-symfony', | ||
| 'unity', | ||
| 'unreal', | ||
| 'native', | ||
| ]); | ||
| export const withoutLoggingSupport: Set<PlatformKey> = new Set(['elixir']); | ||
|
|
||
| // List of platforms that have metrics onboarding checklist content | ||
| export const withMetricsOnboarding: Set<PlatformKey> = new Set([ |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
JoshuaMoelans
force-pushed
the
joshua/fix/update_logging_support
branch
from
500b8af to
be51b21
Compare
|
@priscilawebdev since Unity logs are now coming to the docs, could we merge this one? |
Removed 'dotnet', 'unreal', and 'native' from the withoutLoggingSupport set.
Removed platforms 'cocoa-objc' and 'cocoa-swift' from the withoutLoggingSupport set and re-added 'unreal'.
Removed 'unreal' from the list of platforms without logging support.
JoshuaMoelans
force-pushed
the
joshua/fix/update_logging_support
branch
from
be51b21 to
22ed343
Compare
Removed 'cocoa', 'dotnet', 'symfony', 'unity', 'unreal' and 'native' from the withoutLoggingSupport set, since they have all been released: