Skip to content

feat(Replay): Strip Dash Before EAP Replay Query #103793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
Merged

feat(Replay): Strip Dash Before EAP Replay Query #103793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sentry/replays/endpoints/organization_replay_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ def query_replay_instance_eap(
request_user_id: int | None,
referrer: str = "replays.query.details_query",
):
# EAP stores replay_id in hex without dashes
replay_ids_no_dashes = [replay_id.replace("-", "") for replay_id in replay_ids]

Copy link
Contributor

@cursor cursor bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: EAP query returns incomplete data

The EAP query selects only a subset of fields compared to the non-EAP query path, which returns all fields from QUERY_ALIAS_COLUMN_MAP when fields=[]. Critical missing fields include trace_ids, error_ids, warning_ids, info_ids, user fields, environment, tags, urls, releases, replay_type, platform, dist, duration, activity, sdk, os, browser, device, ota_updates, click fields, and viewed_by_ids. This causes the EAP endpoint to return incomplete replay details compared to the standard query path.

Fix in Cursor Fix in Web

select = [
Column("replay_id"),
Function("min", parameters=[Column("project_id")], alias="agg_project_id"),
Expand Down Expand Up @@ -71,7 +74,7 @@ def query_replay_instance_eap(
match=Entity("replays"),
select=select,
where=[
Condition(Column("replay_id"), Op.IN, replay_ids),
Condition(Column("replay_id"), Op.IN, replay_ids_no_dashes),
Copy link
Contributor

@cursor cursor bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing WHERE conditions in EAP query

The EAP query is missing critical WHERE conditions for project_id and timestamp that filter results to the specified projects and time range. The function receives project_ids, start, and end parameters but doesn't use them in the query, potentially returning replays from any project and any time period instead of the requested scope. Additionally, the query lacks a HAVING clause to ensure segment_id = 0 exists, which validates replay completeness.

Fix in Cursor Fix in Web

],
groupby=[Column("replay_id")],
granularity=Granularity(3600),
Expand Down
Loading