-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore(spans-migration): add isolation scope to misfire and action tags in alerts comparison #103816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| scope.set_tag("false_positive_misfires", false_positive_misfire) | ||
| scope.set_tag("false_negative_misfires", false_negative_misfire) | ||
| for trigger_action_type, count in trigger_action_types.items(): | ||
| scope.set_tag(f"trigger_action_type.{trigger_action_type}", count) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Misfire tags captured in scope with no event
The isolation scope at lines 330-334 sets misfire and trigger action tags but doesn't capture any event within that scope. The tags exit the scope without being associated with any Sentry event, making them ineffective. These tags should either be moved into the isolation scope where capture_message is called at line 352, or capture_message should be called within this scope.
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
was getting scope bleed for the trigger action counts so adding in the isolation scope