WIP: Clean up after full attachments rollout #104092
Draft
+261
−2,015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
❌ 6 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Swatinem
force-pushed
the
swatinem/shiny-future-attachment
branch
from
3eb26a1 to
373fa6c
Compare
Swatinem
force-pushed
the
swatinem/shiny-future-attachment
branch
from
373fa6c to
0167520
Compare
This cleans up the codebase after attachmens on objectstore has been fully rolled out. It assumes that attachments are now fully stored from within relay, and assumes that no attachment chunks will ever be emitted. Thus, there is no more need for the attachments cache, or the chunk message handlers. All feature flags related to objectstore rollout are removed and hardcoded.
Swatinem
force-pushed
the
swatinem/shiny-future-attachment
branch
from
0167520 to
58fd0d4
Compare
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the codebase after attachmens on objectstore has been fully rolled out. It assumes that attachments are now fully stored from within relay, and assumes that no attachment chunks will ever be emitted.
Thus, there is no more need for the attachments cache, or the chunk message handlers. All feature flags related to objectstore rollout are removed and hardcoded.