Skip to content

fix(eventstream): Use an arroyo producer for eventstream #104763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evanh wants to merge 9 commits into from
Closed

fix(eventstream): Use an arroyo producer for eventstream #104763

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f945618
fix(eventstream): Use an arroyo producer for eventstream
evanh Dec 11, 2025
da4f2e5
just use arroyo producer
evanh Dec 11, 2025
6ed0cab
fix some usage bugs
evanh Dec 11, 2025
043f1e1
fix tests/bugs
evanh Dec 12, 2025
3529da8
fixes
evanh Dec 12, 2025
f857748
fix type bug
evanh Dec 15, 2025
ded3d09
Merge branch 'master' into evanh/fix/evenstream-kafka-producer
evanh Dec 17, 2025
05d896e
type fixing
evanh Dec 17, 2025
7889ef8
fix future
evanh Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/sentry/eventstream/kafka/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from sentry.eventstream.types import EventStreamEventType
from sentry.killswitches import killswitch_matches_context
from sentry.utils import json
from sentry.utils.confluent_producer import get_confluent_producer
from sentry.utils.arroyo_producer import get_arroyo_producer
from sentry.utils.kafka_config import get_kafka_producer_cluster_options, get_topic_definition

EAP_ITEMS_CODEC: Codec[TraceItem] = get_topic_codec(Topic.SNUBA_ITEMS)
Expand Down Expand Up @@ -48,9 +48,12 @@ def get_producer(self, topic: Topic) -> Producer:
cluster_name = get_topic_definition(topic)["cluster"]
cluster_options = get_kafka_producer_cluster_options(cluster_name)
cluster_options["client.id"] = "sentry.eventstream.kafka"
# XXX(markus): We should use `sentry.utils.arroyo_producer.get_arroyo_producer`.
self.__producers[topic] = get_confluent_producer(
build_kafka_producer_configuration(default_config=cluster_options)
config = build_kafka_producer_configuration(default_config=cluster_options)
config["queue.buffering.max.messages"] = 200000
self.__producers[topic] = get_arroyo_producer(
name="sentry.eventstream.kafka",
topic=topic,
additional_config=cluster_options,
)

return self.__producers[topic]
Expand Down
Loading