dev: Prevent using now() without UTC #105241
Draft
+189
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a custom commit check to prevent using `datetime.now()` and `datetime.utcnow()`. When devs modify files containing the bad pattern it will be fixed.
github-actions
bot
added
the
Scope: Backend
Member
Author
|
@JoshFerge I'm happy to remove all the AGENTS.md information and see if any of it will be needed in the future. |
JoshFerge
reviewed
Dec 18, 2025
| self.errors.append((keyword.lineno, keyword.col_offset, S011_msg)) | ||
|
|
||
| # S015: Check for datetime.now() or datetime.utcnow() without UTC | ||
| if isinstance(node.func, ast.Attribute): |
Member
There was a problem hiding this comment.
it might be worth looking at https://pypi.org/project/flake8-datetimez/
Member
Author
|
@sentry review |
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a custom commit check to prevent using
datetime.now()anddatetime.utcnow().When devs modify files containing the bad pattern it will be fixed.