fix(search): Prevent IndexError in get_teams_for_users with empty projects #105259
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an
IndexError: list index out of rangethat occurred insentry/search/utils.py:get_teams_for_users.Root Cause
The function attempts to access
projects[0].organization_idto determine the organization context for queryingOrganizationMemberandOrganizationMemberTeam.If the
projectslist passed to this utility function is empty (which can happen when filtering the Detector API index endpoint if the user has no accessible projects or no projects match the initial filters), the list access fails.Fix
Added an early return check at the beginning of
get_teams_for_usersto return an empty list ifprojectsis empty, ensuring the function handles this valid edge case gracefully.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.