Skip to content

replay: use icon variant #105299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JonasBa wants to merge 1 commit into from
Closed

replay: use icon variant #105299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions static/app/views/replays/selectors/deadRageSelectorCards.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ import Placeholder from 'sentry/components/placeholder';
import QuestionTooltip from 'sentry/components/questionTooltip';
import TextOverflow from 'sentry/components/textOverflow';
import {IconCursorArrow, IconSearch} from 'sentry/icons';
import type {SVGIconProps} from 'sentry/icons/svgIcon';
import {t, tct} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import useDeadRageSelectors from 'sentry/utils/replays/hooks/useDeadRageSelectors';
import type {ColorOrAlias} from 'sentry/utils/theme';
import {useLocation} from 'sentry/utils/useLocation';
import {
HeaderContainer,
Expand Down Expand Up @@ -95,12 +95,12 @@ function AccordionWidget({
});
const location = useLocation();
const filteredData = data.filter(d => (d[clickType] ?? 0) > 0);
const clickColor = deadOrRage === 'dead' ? 'yellow300' : 'red300';
const iconVariant = deadOrRage === 'dead' ? 'warning' : 'danger';

return (
<StyledWidgetContainer data-test-id="selector-widget">
<StyledHeaderContainer>
<IconCursorArrow color={clickColor} />
<IconCursorArrow variant={iconVariant} />
{header}
</StyledHeaderContainer>
{isLoading ? (
Expand Down Expand Up @@ -139,7 +139,7 @@ function AccordionWidget({
<AccordionItemHeader
count={d[clickType] ?? 0}
selector={d.dom_element.selector}
clickColor={clickColor}
iconVariant={iconVariant}
selectorQuery={selectorQuery}
id={d.project_id}
/>
Expand All @@ -163,20 +163,20 @@ function AccordionWidget({

function AccordionItemHeader({
count,
clickColor,
iconVariant,
selector,
selectorQuery,
id,
}: {
clickColor: ColorOrAlias;
count: number;
iconVariant: SVGIconProps['variant'];
id: number;
selector: string;
selectorQuery: string;
}) {
const clickCount = (
<ClickCount>
<IconCursorArrow size="xs" color={clickColor} />
<IconCursorArrow size="xs" variant={iconVariant} />
{count}
</ClickCount>
);
Expand Down
Loading