fix(code-review): Update legacy feature enablement switch #105314
Conversation
github-actions
bot
added
the
Scope: Frontend
suejung-sentry
force-pushed
the
sshin/fix-toggle
branch
from
ba4a2b8 to
c88772d
Compare
| ), | ||
| }), | ||
| visible: ({model}) => { | ||
| if (showNewSeer(organization)) { |
There was a problem hiding this comment.
This showNewSeer() call should already be handling the case
There was a problem hiding this comment.
I didn't see showNewSeer() handling those in code-review-beta cohort (whether on old seer plan, new seer plan, or neither)
There was a problem hiding this comment.
There's a comment in there that it should be handled... but it's not.
We should add a check for the flag inside that function, to match the comment. that'll also mean the other places that call showNewSeer() will be aligned as well.
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Update legacy feature enablement switch so it does NOT show for new seat-based plan orgs. It still shows for legacy payg seer orgs and code-review-beta orgs (that are not on the new seat-based plan).