theme: remove theme.white and theme.black #105337
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
commented
Dec 19, 2025
Comment on lines
+55
to
+61
| const StyledIconClock = styled(IconClock)` | ||
| color: ${p => p.theme.colors.white}; | ||
| `; | ||
|
|
||
| const StyledIconLightning = styled(IconLightning)` | ||
| color: ${p => p.theme.colors.white}; | ||
| `; |
Member
Author
There was a problem hiding this comment.
This is an example where we need to escape via styled.
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the deprecated theme black and white colors. For Icon changes, use styled to draw color as white (most cases are when icons are used in buttons, which will in the future work ootb)