-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix(errors): Add error.received to timestamp fields #105713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(errors): Add error.received to timestamp fields #105713
Conversation
|
@sentry review |
wmak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer an additional integration test to make sure this continues to pass even as discover becomes deprecated. See OrganizationEventsErrorsDatasetEndpointTest for examples of how that's done
I believe I now have these all covered, also cursor raised a potential issue that i also incorporated around using the timestamp constant in |
wmak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Worked with the AI's to resolve this issue, according to Opus the issue was:
Ticket: EXP-632