Skip to content

Conversation

@nsdeschenes
Copy link
Contributor

Worked with the AI's to resolve this issue, according to Opus the issue was:

The error.received field is correctly recognized as a date field for parsing (it's in date_keys in event_search.py), but when the filter is built in default_filter_converter, it checks TIMESTAMP_FIELDS to decide whether to keep the datetime as a string or convert it to an epoch integer.

Since error.received is not in this set, the datetime gets converted to epoch milliseconds (int(value.timestamp()) * 1000), but the underlying snuba received column expects a DateTime string for comparison—not an epoch integer.

This causes the filter to not work correctly because you're comparing a DateTime column against an integer value.

Ticket: EXP-632

@linear
Copy link

linear bot commented Jan 6, 2026

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 6, 2026
@nsdeschenes
Copy link
Contributor Author

@sentry review

@nsdeschenes nsdeschenes marked this pull request as ready for review January 6, 2026 16:18
@nsdeschenes nsdeschenes requested review from a team as code owners January 6, 2026 16:18
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer an additional integration test to make sure this continues to pass even as discover becomes deprecated. See OrganizationEventsErrorsDatasetEndpointTest for examples of how that's done

@nsdeschenes
Copy link
Contributor Author

I'd prefer an additional integration test to make sure this continues to pass even as discover becomes deprecated. See OrganizationEventsErrorsDatasetEndpointTest for examples of how that's done

I believe I now have these all covered, also cursor raised a potential issue that i also incorporated around using the timestamp constant in filters.py, over redefining the values. Seems like that file already used things from that constants file like ARRAY_FIELDS so should be a small improvement.

Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants