feat(dashboards): allow prebuilt dashboards to hardcode units #105743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/dashboards/widgetCard/genericWidgetQueries.tsx
Outdated
Show resolved
Hide resolved
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
static/app/views/dashboards/widgetCard/genericWidgetQueries.tsx
Outdated
Show resolved
Hide resolved
gggritso
reviewed
Jan 7, 2026
Member
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
Makes sense overall, thanks! I think you can wait for Nar's PR (mentioned in comments) to land, and it'll make your life easier here 👍🏻
…centage-units-in-dashboard-json
…centage-units-in-dashboard-json
narsaynorath
approved these changes
Jan 7, 2026
static/app/views/dashboards/widgetCard/genericWidgetQueries.tsx
Outdated
Show resolved
Hide resolved
narsaynorath
approved these changes
Jan 7, 2026
DominikB2014
deleted the
dominikbuszowiecki/browse-218-hardcode-percentage-units-in-dashboard-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several equations that have no units (all percentage based ones in this case), this PR allows us to define units for prebuilt dashboards. Eventually we could make this a field in the db, and allow it to be clone able/user customizable.
There's some wacky stuff I had to do to get the units working for line charts that have a groupby, the series name isn't the equation name in that case, it's the group name. So there's no easy way to map between the two. Please let me know if you have any better suggestions here.