ref(core): simplify AlertBadge logic
#105958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
approved these changes
Jan 8, 2026
natemoo-re
added a commit
that referenced
this pull request
Jan 9, 2026
Removes `theme.subText`, closes DE-329 In simple cases with the `color` property, these have been replaced with `theme.tokens.content.secondary`. I flagged a handful of non-text CSS Properties, which have been converted to the semantically appropriate alternative—these are worth taking a second look at commit-by-commit. | File | Note | | ----------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------- | | [alertBadge.tsx](https://github.com/getsentry/sentry/blob/theme/nm/subtext/static/app/components/core/badge/alertBadge.tsx) | fixed in #105958 | | [plainTextQueryInput.tsx](f586dbe) | caret-color, use `interactive` token | | [slider/index.tsx](3e7fc4f#diff-0a69d0a60b1bfaec2dff5b91f6da5671596844b478955f25c985b5b4a2aa0af9R370) | disabled, use `content.disabled` | | [slider/thumb.tsx](3e7fc4f#diff-dcd54696903075c19dd63b3d73eac8e70e71e340ac12406497fb7f7186b6dff0R107-R108) | disabled, use `content.disabled` | | [metricChart.tsx](648acd0) | background, use `graphics.neutral.vibrant` | | [ruleForm.tsx](c0df95d) | background, use `graphics.neutral.vibrant` | | [baseAvatar.tsx](20ff270) | border, use `border.neutral.vibrant`| --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this in the course of #105851 and decided to refactor
AlertBadgeto align the logic to the new token structure and simplify the functions.