Skip to content

fix(a11y): add missing alt attributes to context icons and feedback images #115772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryan953 merged 10 commits into from
May 26, 2026
Merged

fix(a11y): add missing alt attributes to context icons and feedback images #115772

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1d56e14
fix(a11y): add missing alt attributes to context icons and feedback i…
May 19, 2026
e45c6f5
Merge branch 'master' into fix/add-alt-to-context-icon-and-feedback-i…
ryan953 May 26, 2026
37a2a4f
Apply suggestions from code review
ryan953 May 26, 2026
be202ff
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] May 26, 2026
9df7562
fix(a11y): use name as alt text inside ContextIcon
sentry-junior[bot] May 26, 2026
e9a7ed6
:hammer_and_wrench: apply pre-commit fixes
getsantry[bot] May 26, 2026
1960079
fix(a11y): type context icon alt text
cursoragent May 26, 2026
c6ca515
fix(a11y): avoid spreading context icon props
cursoragent May 26, 2026
87971b9
fix(a11y): back out context icon alt change
cursoragent May 26, 2026
384191a
Apply suggestion from @ryan953
ryan953 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion static/app/components/events/contexts/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,9 @@
if (getLogoImage(iconName) === null) {
return null;
}
return <ContextIcon name={iconName} {...contextIconProps} />;
return (
<ContextIcon name={iconName} alt={`${type}: ${iconName}`} {...contextIconProps} />

Check failure on line 367 in static/app/components/events/contexts/utils.tsx

View workflow job for this annotation

GitHub Actions / typescript 

Type '{ size?: "2xl" | "lg" | "md" | "sm" | "xl" | "xs" | undefined; name: string; alt: string; }' is not assignable to type 'IntrinsicAttributes & ContextIconProps'.

@sentry sentry Bot May 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The ContextIcon component receives an alt prop, but it's not declared in its props or used, so the accessibility text is silently ignored.
Severity: LOW

Suggested Fix

Update the ContextIcon component to accept and use the alt prop. Add alt to the ContextIconProps interface, destructure it in the component's function signature, and pass it to the underlying rendered element that requires the accessibility text.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: static/app/components/events/contexts/utils.tsx#L367

Potential issue: The `ContextIcon` component is passed an `alt` prop from `utils.tsx` to
provide accessibility text. However, the component's props interface,
`ContextIconProps`, does not declare `alt`, and the function signature only destructures
the `name` and `size` props. Consequently, the `alt` prop is silently ignored by React
and not passed down to the underlying `PlatformIcon` component. This results in the
intended accessibility improvement being non-functional, as no alternative text is
rendered for the icon.

Did we get this right? 👍 / 👎 to inform future reviews.

);
}

export function getFormattedContextData({
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/feedback/feedbackSetupPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function FeedbackSetupPanel() {
<NoMarginPanel>
<Container>
<IlloBox>
<img src={feedbackOnboardingImg} />
<img src={feedbackOnboardingImg} alt="" />
</IlloBox>
<StyledBox>
<Fragment>
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/feedback/feedbackEmptyState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export function FeedbackEmptyState({projectIds, issueTab = false}: Props) {
return (
<OnboardingPanel
data-test-id="user-feedback-empty"
image={<img src={emptyStateImg} />}
image={<img src={emptyStateImg} alt="" />}
>
<h3>{t('What do users think?')}</h3>
<p>
Expand Down
Loading