Skip to content

fix(detectors): Additional SQL Injection Detector improvements #93181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

roggenkemper
Copy link
Member

this pr adds a few additional improvements to the SQL Injection Detector:

  • Increases the minimum character count to 3
  • Adds a few additional keywords to not match on
  • adds word boundaries during lookup. this won't be perfect but should help narrow down where further improvements are needed

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93181      +/-   ##
==========================================
- Coverage   87.88%   86.68%   -1.21%     
==========================================
  Files       10311    10313       +2     
  Lines      592184   592324     +140     
  Branches    23052    23052              
==========================================
- Hits       520463   513458    -7005     
- Misses      71285    78430    +7145     
  Partials      436      436              

@roggenkemper roggenkemper marked this pull request as ready for review June 9, 2025 22:19
@roggenkemper roggenkemper requested review from a team as code owners June 9, 2025 22:19
@roggenkemper roggenkemper merged commit efe3d5f into master Jun 10, 2025
61 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/sqlinjectionfix3 branch June 10, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants