Skip to content

ref: stricter typing for a few utils modules #93184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team June 9, 2025 22:07
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 9, 2025 22:07
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/utils/kafka.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93184       +/-   ##
===========================================
+ Coverage   46.14%   87.89%   +41.74%     
===========================================
  Files       10296    10311       +15     
  Lines      591455   592189      +734     
  Branches    23050    23050               
===========================================
+ Hits       272954   520482   +247528     
+ Misses     318065    71271   -246794     
  Partials      436      436               

@asottile-sentry asottile-sentry merged commit a82eeb9 into master Jun 10, 2025
62 checks passed
@asottile-sentry asottile-sentry deleted the asottile-stricter-typing-a-few-modules branch June 10, 2025 18:05
andrewshie-sentry pushed a commit that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants