Skip to content

🔧 chore: change slack service activity notif to debug level #93188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

🔧 chore: change slack service activity notif to debug level #93188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d930d0
:wrench: chore: change slack service activity notif to debug level
iamrajjoshi Jun 9, 2025
75eebd5
:wrench: chore: fix tests
iamrajjoshi Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/sentry/integrations/slack/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def notify_all_threads_for_activity(self, activity: Activity) -> None:
}

if activity.group is None:
self._logger.info(
self._logger.debug(
"no group associated on the activity, nothing to do",
extra=log_params,
)
Expand All @@ -156,7 +156,8 @@ def notify_all_threads_for_activity(self, activity: Activity) -> None:
)

if activity.user_id is None and not uptime_resolved_notification:
self._logger.info(
# This is a machine/system update, so we don't need to send a notification
self._logger.debug(
"machine/system updates are ignored at this time, nothing to do",
extra=log_params,
)
Expand Down
4 changes: 2 additions & 2 deletions tests/sentry/integrations/slack/service/test_slack_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ def test_none_group(self):

with mock.patch.object(self.service, "_logger") as mock_logger:
self.service.notify_all_threads_for_activity(activity=self.activity)
mock_logger.info.assert_called_with(
mock_logger.debug.assert_called_with(
"no group associated on the activity, nothing to do",
extra={
"activity_id": self.activity.id,
Expand All @@ -141,7 +141,7 @@ def test_none_user_id(self):

with mock.patch.object(self.service, "_logger") as mock_logger:
self.service.notify_all_threads_for_activity(activity=self.activity)
mock_logger.info.assert_called_with(
mock_logger.debug.assert_called_with(
"machine/system updates are ignored at this time, nothing to do",
extra={
"activity_id": self.activity.id,
Expand Down
Loading