Skip to content

feat(aci): Add pagination to detector list page #93190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented Jun 9, 2025

Simple addition of the <Pagination /> component and hooking up to the URL

@malwilley malwilley requested a review from a team as a code owner June 9, 2025 23:00
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10538 1 10537 9
View the top 1 failed test(s) by shortest run time
provisionSubscriptionAction calls api with correct manually invoiced on-demand args
Stack Traces | 15.2s run time
Error: thrown: "Exceeded timeout of 15000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at .../gsAdmin/components/provisionSubscriptionAction.spec.tsx:1191:3
    at _dispatchDescribe (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/index.js:91:26)
    at describe (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/index.js:55:5)
    at Object.<anonymous> (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:13:1)
    at Runtime._execModule (.../sentry/node_modules/.pnpm/[email protected]..../jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/node_modules/.pnpm/[email protected]..../jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/node_modules/.pnpm/[email protected]..../jest-runtime/build/index.js:882:12)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@malwilley malwilley force-pushed the malwilley/feat/detector-list-pagination branch from 93fb087 to 808a0f9 Compare June 10, 2025 18:29
@malwilley malwilley merged commit c9d184e into master Jun 10, 2025
42 checks passed
@malwilley malwilley deleted the malwilley/feat/detector-list-pagination branch June 10, 2025 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants