feat(aci): add sentry app action details to conditions panel #93193
Conversation
github-actions
bot
added
the
Scope: Frontend
| @@ -1,6 +1,7 @@ | |||
| export interface Action { | |||
| config: { | |||
| target_type: ActionTarget; | |||
| sentry_app_identifier?: SentryAppIdentifier; | |||
There was a problem hiding this comment.
Are these keys something we are going to try to camelcase at some point?
There was a problem hiding this comment.
we definitely should camelcase them at some point, but the api currently returns them in snakecase 😞
| const name = handler?.sentryApp?.name; | ||
| const title = handler?.sentryApp?.title; | ||
|
|
||
| return title || name; |
There was a problem hiding this comment.
Do we need a fallback here? This will render undefined if neither title or name are available
| import {useActionNodeContext} from 'sentry/views/automations/components/actionNodes'; | ||
| import {SentryAppActionSettingsButton} from 'sentry/views/automations/components/actions/sentryAppSettingsButton'; | ||
|
|
||
| export function SentryAppDetails({handler}: {handler: ActionHandler}) { | ||
| const name = handler?.sentryApp?.name; |
There was a problem hiding this comment.
What is the difference between a name and a title? Might be good context to add somewhere for future code readers
There was a problem hiding this comment.
good point i've added a comment to the type, name is the name of the sentry app while title is the action that the sentry app performs (for example "Create a Linear issue")
| name: string; | ||
| status: number; | ||
| settings?: Record<string, any>; | ||
| // title represents the action being performed by the SentryApp |
There was a problem hiding this comment.
If you put this in a multiline comment block (with the /* * */), IDEs will pick up on it when you start typing out properties which is helpful. I usually do that when documenting type properties like this
There was a problem hiding this comment.
i got a linting error when i did this 😳
Expected multiple line comments instead of a block comment.eslint[multiline-comment-style](https://eslint.org/docs/latest/rules/multiline-comment-style)
There was a problem hiding this comment.
You won't get a lint error if you do e.g.:
/**
* The response status code
*/
status: Response['status'];
added logic to look up the correct action handler depending on the sentry app identifier provided by the action