Skip to content

feat(aci): Add available detector types to validation error #93203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2025

Conversation

scttcper
Copy link
Member

Displays the available types on error which I was finding difficult when trying to use these endpoints.

Displays the available types on error which I was finding difficult when trying to use these endpoints.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 10, 2025
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
..._engine/endpoints/organization_detector_details.py 33.33% 2 Missing ⚠️
...ntry/workflow_engine/endpoints/validators/utils.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93203       +/-   ##
===========================================
+ Coverage   41.24%   87.99%   +46.75%     
===========================================
  Files       10232    10257       +25     
  Lines      590904   591715      +811     
  Branches    23000    22983       -17     
===========================================
+ Hits       243701   520671   +276970     
+ Misses     346712    70553   -276159     
  Partials      491      491               

@scttcper scttcper marked this pull request as ready for review June 10, 2025 16:45
@scttcper scttcper requested review from a team as code owners June 10, 2025 16:45
Copy link
Member

@ceorourke ceorourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f

@scttcper scttcper merged commit 5c157ce into master Jun 10, 2025
61 checks passed
@scttcper scttcper deleted the scttcper/detector-types branch June 10, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants