feat(screenshots): Update render logic #93211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
changed the title
…ame-contains-screenshot
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93211 +/- ##
==========================================
- Coverage 85.31% 82.91% -2.41%
==========================================
Files 10256 10255 -1
Lines 591639 591622 -17
Branches 22990 22986 -4
==========================================
- Hits 504768 490517 -14251
- Misses 86380 100465 +14085
- Partials 491 640 +149 |
ArthurKnaus
approved these changes
Jun 10, 2025
|
|
||
| export function WebMViewer(props: WebMViewerProps) { | ||
| export function WebMViewer({controls = true, onCanPlay, ...props}: WebMViewerProps) { |
There was a problem hiding this comment.
Out of curiosity: Why do we limit this to WebM? Couldn't we try to display any video type?
There was a problem hiding this comment.
We must rethink these components and refactor them. Agree that we could have something like VideoViewer or something.
priscilawebdev
deleted the
priscila/feat/screenshots/render-file-if-name-contains-screenshot
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #92154
This PR updates our logic for rendering screenshots, essentially removing the extension checks to match what the backend does.
There is a catch. The frontend also checks the mimytpe of the file, and based on that we can either render something or not render anything.
So the file will be rendered if the name contains "screenshot" and if it is one of the file formats we currently support. A new issue will be created where we will introduce files in newer formats, but that is for a follow-up.