Skip to content

ref(dashboards): standardize widget related tables to one table #93434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lzhao-sentry
Copy link
Contributor

@lzhao-sentry lzhao-sentry commented Jun 12, 2025

Changes

Add new widget table component that is shared by widgets on the dashboard, widget preview and widget viewer modal. Will look into renaming/reorganizing files in a separate PR so changes in this PR are easier to see.

Before

Not sure what to record, but basically imagine the below video, but no sorting/resizing of columns exist

After

newwidgettable.mov

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 12, 2025
Copy link

codecov bot commented Jun 12, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10568 1 10567 9
View the top 1 failed test(s) by shortest run time
provisionSubscriptionAction calls api with correct manually invoiced on-demand args
Stack Traces | 15.3s run time
Error: thrown: "Exceeded timeout of 15000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at .../gsAdmin/components/provisionSubscriptionAction.spec.tsx:1191:3
    at _dispatchDescribe (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/index.js:91:26)
    at describe (.../sentry/node_modules/.pnpm/[email protected][email protected]..../jest-circus/build/index.js:55:5)
    at Object.<anonymous> (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:13:1)
    at Runtime._execModule (.../sentry/node_modules/.pnpm/[email protected]..../jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../sentry/node_modules/.pnpm/[email protected]..../jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../sentry/node_modules/.pnpm/[email protected]..../jest-runtime/build/index.js:882:12)
    at jestAdapter (.../sentry/node_modules/.pnpm/[email protected][email protected]..../build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/node_modules/.pnpm/[email protected]..../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@lzhao-sentry lzhao-sentry marked this pull request as ready for review June 12, 2025 17:48
@lzhao-sentry lzhao-sentry requested review from a team as code owners June 12, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant