Skip to content

fix(ui): Consistent can-not-edit alerts in settings #93467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner June 12, 2025 18:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 12, 2025
@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team June 12, 2025 18:36
Copy link
Member

@ArthurKnaus ArthurKnaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/fix-ui-consistent-can-not-edit-alerts-in-settings branch from c891fee to 83489e7 Compare June 12, 2025 19:23
Copy link

codecov bot commented Jun 12, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10569 1 10568 9
View the top 1 failed test(s) by shortest run time
useReplayData should incrementally load attachments and errors
Stack Traces | 1.08s run time
Error: expect(received).toStrictEqual(expected) // deep equality

- Expected  -  2
+ Received  + 30

@@ -1,6 +1,7 @@
- ObjectContaining {
+ Object {
+   "attachmentError": Array [],
    "attachments": Array [
      Object {
        "data": Object {},
        "timestamp": 1672592400000,
        "type": 0,
@@ -18,11 +19,37 @@
        },
        "timestamp": 1672592400000,
        "type": 4,
      },
    ],
-   "errors": Array [],
+   "errors": Array [
+     Object {
+       "error.type": Array [],
+       "error.value": Array [],
+       "id": "5c83aaccfffb4a708ae893bad9be3a1c",
+       "issue": "JAVASCRIPT-123E",
+       "issue.id": 3740335939,
+       "project.name": "javascript",
+       "timestamp": "2023-01-01T17:00:00.000Z",
+       "title": "A Redirect with :orgId param on customer domain",
+     },
+     Object {
+       "error.type": Array [],
+       "error.value": Array [],
+       "id": "5c83aaccfffb4a708ae893bad9be3a1c",
+       "issue": "JAVASCRIPT-123E",
+       "issue.id": 3740335939,
+       "project.name": "javascript",
+       "timestamp": "2023-01-01T17:00:00.000Z",
+       "title": "A Redirect with :orgId param on customer domain",
+     },
+   ],
+   "fetchError": undefined,
+   "isError": false,
+   "isPending": false,
+   "onRetry": [Function anonymous],
+   "projectSlug": "project-slug",
    "replayRecord": Object {
      "activity": 0,
      "browser": Object {
        "name": "Other",
        "version": "",
@@ -103,6 +130,7 @@
        "id": "",
        "ip": "127.0.0.1",
        "username": "",
      },
    },
+   "status": "success",
  }

Ignored nodes: comments, script, style
...
    at .../replays/hooks/useReplayData.spec.tsx:431:74
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/node_modules/.pnpm/@[email protected]/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/node_modules/.pnpm/[email protected]..../jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:594:17)
    at processTimers (node:internal/timers:529:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/fix-ui-consistent-can-not-edit-alerts-in-settings branch from 83489e7 to 3cb0e92 Compare June 12, 2025 20:52
@evanpurkhiser evanpurkhiser merged commit 9db6625 into master Jun 13, 2025
42 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/fix-ui-consistent-can-not-edit-alerts-in-settings branch June 13, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants