Skip to content

feat(trace-eap-waterfall): Only rendering context section if data exists #93468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abdkhan14 merged 3 commits into from
Jun 13, 2025
Merged

feat(trace-eap-waterfall): Only rendering context section if data exists #93468

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4633de5
feat(trace-eap-waterfall): Only rendering context section if data exists
Jun 12, 2025
0544827
Merge branch 'master' into abdk/trace-eap-context-sections
Abdkhan14 Jun 12, 2025
dc85cea
Merge branch 'master' into abdk/trace-eap-context-sections
Abdkhan14 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions static/app/views/performance/newTraceDetails/traceDrawer/details/span/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import LoadingIndicator from 'sentry/components/loadingIndicator';
import QuestionTooltip from 'sentry/components/questionTooltip';
import {t} from 'sentry/locale';
import {space} from 'sentry/styles/space';
import type {EventTransaction} from 'sentry/types/event';
import {EntryType, type EventTransaction} from 'sentry/types/event';
import type {NewQuery, Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import {defined} from 'sentry/utils';
Expand Down Expand Up @@ -409,6 +409,10 @@ function EAPSpanNodeDetails({
const profileId =
typeof profileMeta === 'string' ? profileMeta : profileMeta.profiler_id;

const eventHasRequestEntry = eventTransaction?.entries.some(
entry => entry.type === EntryType.REQUEST
);

return (
<TraceDrawerComponents.DetailContainer>
<SpanNodeDetailHeader
Expand Down Expand Up @@ -482,7 +486,7 @@ function EAPSpanNodeDetails({
/>
</FoldSection>

{isTransaction ? (
{isTransaction && eventHasRequestEntry ? (
<FoldSection
sectionKey={SectionKey.CONTEXTS}
title={
Expand Down
Loading