Skip to content

js: misc yarn cleanup #93474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/actions/setup-sentry/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ inputs:
default: 'default'

outputs:
yarn-cache-dir:
description: 'Path to yarn cache'
value: ${{ steps.config.outputs.yarn-cache-dir }}
matrix-instance-number:
description: 'The matrix instance number (starting at 1)'
value: ${{ steps.config.outputs.matrix-instance-number }}
Expand Down Expand Up @@ -94,7 +91,6 @@ runs:
MATRIX_INSTANCE: ${{ matrix.instance }}
shell: bash --noprofile --norc -eo pipefail -ux {0}
run: |
echo "yarn-cache-dir=$(yarn cache dir)" >> "$GITHUB_OUTPUT"
echo "matrix-instance-number=$(($MATRIX_INSTANCE+1))" >> "$GITHUB_OUTPUT"
echo "matrix-instance-total=$((${MATRIX_INSTANCE_TOTAL:-}))" >> "$GITHUB_OUTPUT"

Expand Down
2 changes: 1 addition & 1 deletion Brewfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ brew 'qemu'
brew 'docker'
brew 'docker-buildx'

# required for yarn test -u
# required for pnpm test -u
brew 'watchman'

# direnv isn't defined here, because we have it configured to check for a bootstrapped environment.
Expand Down
4 changes: 2 additions & 2 deletions rspack.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ const appConfig: Configuration = {
stream: false,
// Node crypto is imported in @sentry-internal/global-search but not used here
crypto: false,
// `yarn why` says this is only needed in dev deps
// `pnpm why` says this is only needed in dev deps
string_decoder: false,
// For framer motion v6, might be able to remove on v11
'process/browser': require.resolve('process/browser'),
Expand Down Expand Up @@ -653,7 +653,7 @@ if (IS_UI_DEV_ONLY) {
return slug;
};

// Try and load certificates from mkcert if available. Use $ yarn mkcert-localhost
// Try and load certificates from mkcert if available. Use $ pnpm mkcert-localhost
const certPath = path.join(__dirname, 'config');
const httpsOptions = fs.existsSync(path.join(certPath, 'localhost.pem'))
? {
Expand Down
2 changes: 1 addition & 1 deletion src/sentry/charts/chartcuterie.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def generate_chart(self, style: ChartType, data: Any, size: ChartSize | None = N

if resp.status_code == 503 and settings.DEBUG:
logger.info(
"You may need to build the chartcuterie config using `yarn build-chartcuterie-config`"
"You may need to build the chartcuterie config using `pnpm build-chartcuterie-config`"
)

if resp.status_code != 200:
Expand Down
2 changes: 1 addition & 1 deletion static/app/utils/profiling/profile/profile.benchmark.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Benchmarks allow us to make changes and evaluate performance before the code gets shipped to production.
// They can be used to make performance improvements or to test impact of newly added functionality.

// Run with: yarn run ts-node --project ./config/tsconfig.benchmark.json -r tsconfig-paths/register static/app/utils/profiling/profile/profile.benchmark.ts
// Run with: pnpm run ts-node --project ./config/tsconfig.benchmark.json -r tsconfig-paths/register static/app/utils/profiling/profile/profile.benchmark.ts

// @ts-expect-error TS(7016): Could not find a declaration file for module 'benc... Remove this comment to see the full error message
import benchmarkjs from 'benchmark';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Benchmarks allow us to make changes and evaluate performance before the code gets shipped to production.
// They can be used to make performance improvements or to test impact of newly added functionality.
// Run with: yarn run ts-node --project ./config/tsconfig.benchmark.json -r tsconfig-paths/register static/app/utils/profiling/renderers/textRenderer.benchmark.ts
// Run with: pnpm run ts-node --project ./config/tsconfig.benchmark.json -r tsconfig-paths/register static/app/utils/profiling/renderers/textRenderer.benchmark.ts
// @ts-expect-error TS(7016): Could not find a declaration file for module 'benc... Remove this comment to see the full error message
import benchmarkjs from 'benchmark';
import maxBy from 'lodash/maxBy';
Expand Down
Loading