ref: fix types for sentry.net.socket #93477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect our socket default code wasn't even working because it did not match urllib3's
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93477 +/- ##
===========================================
+ Coverage 46.23% 88.03% +41.79%
===========================================
Files 10271 10294 +23
Lines 592532 593776 +1244
Branches 23034 23034
===========================================
+ Hits 273933 522705 +248772
+ Misses 318167 70639 -247528
Partials 432 432 |
joshuarli
approved these changes
Jun 12, 2025
wedamija
approved these changes
Jun 12, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
I suspect our socket default code wasn't even working because it did not match urllib3's <!-- Describe your PR here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect our socket default code wasn't even working because it did not match urllib3's