chore(aci): log action ids we'd fire in workflow engine #93480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/sentry/workflow_engine/processors/delayed_workflow.py
Did you find this useful? React with a 👍 or 👎 |
iamrajjoshi
approved these changes
Jun 12, 2025
saponifi3d
reviewed
Jun 12, 2025
Comment on lines
+313
to
+320
| logger.info( | ||
| "workflow_engine.triggered_actions", | ||
| extra={ | ||
| "detector_id": detector.id, | ||
| "action_ids": [action.id for action in actions], | ||
| "event_data": asdict(event_data), | ||
| }, | ||
| ) |
There was a problem hiding this comment.
should this also include the action and detector types to help with filtering? (that'd mean putting it in the for loop below.
There was a problem hiding this comment.
for now i'm ok having this be just ids, i will be setting up some tests that will trigger 1 workflow
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93480 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 10294 10294
Lines 593836 593815 -21
Branches 23044 23044
=======================================
- Hits 522768 522751 -17
+ Misses 70619 70615 -4
Partials 449 449 |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to see which actions we would fire in workflow engine (post-process and delayed processing)