-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(preprod): Add back extras JSONField #93485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # migrations_lockfile.txt
This PR has a migration; here is the generated SQL for for --
-- Remove field extras from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "extras" CASCADE; for --
-- Add field extras to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "extras" jsonb NULL; |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93485 +/- ##
===========================================
- Coverage 88.00% 77.73% -10.28%
===========================================
Files 10319 10308 -11
Lines 594699 594092 -607
Branches 23129 23012 -117
===========================================
- Hits 523376 461821 -61555
- Misses 70830 131839 +61009
+ Partials 493 432 -61 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Conflicts: # migrations_lockfile.txt
This PR has a migration; here is the generated SQL for for --
-- Add field extras to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "extras" jsonb NULL; |
The final PR in our saga to change the type of
extras
->models.JSONField
. This simply adds back the column.See #93466 and #93388