Skip to content

feat(preprod): Add back extras JSONField #93485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 13, 2025
Merged

Conversation

trevor-e
Copy link
Member

The final PR in our saga to change the type of extras -> models.JSONField. This simply adds back the column.

See #93466 and #93388

@trevor-e trevor-e requested a review from a team as a code owner June 12, 2025 22:08
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2025
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0003_drop_sentry_jsonfield_actual.py src/sentry/preprod/migrations/0004_add_django_jsonfield.py

for 0003_drop_sentry_jsonfield_actual in preprod

--
-- Remove field extras from preprodartifact
--
ALTER TABLE "sentry_preprodartifact" DROP COLUMN "extras" CASCADE;

for 0004_add_django_jsonfield in preprod

--
-- Add field extras to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "extras" jsonb NULL;

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #93485       +/-   ##
===========================================
- Coverage   88.00%   77.73%   -10.28%     
===========================================
  Files       10319    10308       -11     
  Lines      594699   594092      -607     
  Branches    23129    23012      -117     
===========================================
- Hits       523376   461821    -61555     
- Misses      70830   131839    +61009     
+ Partials      493      432       -61     

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from telkins/jsonfield-drop to master June 13, 2025 16:33
# Conflicts:
#	migrations_lockfile.txt
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/preprod/migrations/0004_add_django_jsonfield.py

for 0004_add_django_jsonfield in preprod

--
-- Add field extras to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "extras" jsonb NULL;

@trevor-e trevor-e merged commit 5978796 into master Jun 13, 2025
64 checks passed
@trevor-e trevor-e deleted the telkins/jsonfield-django-add branch June 13, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants