feat(workflow_engine): Add registry hook for Activity creation #93522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
…t created the change
…ssagedata diretly
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93522 +/- ##
========================================
Coverage 88.00% 88.01%
========================================
Files 10319 10321 +2
Lines 594699 594923 +224
Branches 23129 23129
========================================
+ Hits 523376 523596 +220
- Misses 70830 70834 +4
Partials 493 493 |
… in update_status. if there's a new activity, get the latest event and trigger the registry
…ue for 'activity_type'
saponifi3d
commented
Jun 13, 2025
Comment on lines
+151
to
+153
| latest_activity = Activity.objects.filter( | ||
| group_id=group.id, type=activity_type.value | ||
| ).order_by("-datetime") |
There was a problem hiding this comment.
don't really like adding this query -- but it's a lot easier than trying to proxy the activity back up through update_group_status as that would require a fairly large change. open to suggestions though 🙏
snigdhas
approved these changes
Jun 13, 2025
billyvg
pushed a commit
that referenced
this pull request
Jun 18, 2025
## Description Starting implementation for: https://www.notion.so/sentry/Workflow-Status-Changes-1fa8b10e4b5d80a48acddb95d160da1f?source=copy_link#1fa8b10e4b5d80e6bb1aef39cab2c6dc This will add a registry of handlers when an activity is created, we'll use this in the [workflow engine to kick-off a task](#93553) to execute `process_workflows`. This also adds a way to pass the detector_id through the StatusMessageData all the way to a hook that we can invoke and read directly from the StatusMessageData later. We are also passed the `activity` so `workflow_engine` can trigger `.send_notification` (if evaluated to do so).
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
## Description Starting implementation for: https://www.notion.so/sentry/Workflow-Status-Changes-1fa8b10e4b5d80a48acddb95d160da1f?source=copy_link#1fa8b10e4b5d80e6bb1aef39cab2c6dc This will add a registry of handlers when an activity is created, we'll use this in the [workflow engine to kick-off a task](#93553) to execute `process_workflows`. This also adds a way to pass the detector_id through the StatusMessageData all the way to a hook that we can invoke and read directly from the StatusMessageData later. We are also passed the `activity` so `workflow_engine` can trigger `.send_notification` (if evaluated to do so).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting implementation for: https://www.notion.so/sentry/Workflow-Status-Changes-1fa8b10e4b5d80a48acddb95d160da1f?source=copy_link#1fa8b10e4b5d80e6bb1aef39cab2c6dc
This will add a registry of handlers when an activity is created, we'll use this in the workflow engine to kick-off a task to execute
process_workflows.This also adds a way to pass the detector_id through the StatusMessageData all the way to a hook that we can invoke and read directly from the StatusMessageData later. We are also passed the
activitysoworkflow_enginecan trigger.send_notification(if evaluated to do so).