ref(browser reporting): Use option to control Reporting-Endpoints header
#93560
+52
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93560 +/- ##
===========================================
+ Coverage 46.30% 88.00% +41.69%
===========================================
Files 10306 10322 +16
Lines 594236 594964 +728
Branches 23141 23141
===========================================
+ Hits 275175 523608 +248433
+ Misses 318568 70863 -247705
Partials 493 493 |
lobsterkatie
force-pushed
the
kmclb-use-option-for-adding-reporting-endpoints-header
branch
from
46da06e to
c8b92a1
Compare
roggenkemper
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches our check for whether to add the
Reporting-Endpointsheader from usingstaff.is_active(which seems to be false even if the user hasis_staff = Truein the database) to using a new option,issues.browser_reporting.reporting_endpoints_header_enabled.