ref(grouping): Add log to grouping config upgrade #93572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, we should only hit the branch of
update_or_set_grouping_config_if_needed
where we're starting with an outdated config and updating it if the project in question has an outdated config. We've long since force-upgraded not only every project on an old config but also every project from an options epoch that would mean it defaults to an old config, so in theory we should no longer be landing in that branch. And yet.In order to debug how we're still seeing the metric from that branch ping, this adds a log with more specific data (like project id) than what we can gather in DataDog.
(The extra weird thing is, DataDog says the upgrades are upgrades from the legacy config, and yet no no new transition periods have started, which they should have if the existing config is a valid one. Very mysterious.)