Skip to content

ref(grouping): Add log to grouping config upgrade #93572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lobsterkatie
Copy link
Member

In theory, we should only hit the branch of update_or_set_grouping_config_if_needed where we're starting with an outdated config and updating it if the project in question has an outdated config. We've long since force-upgraded not only every project on an old config but also every project from an options epoch that would mean it defaults to an old config, so in theory we should no longer be landing in that branch. And yet.

In order to debug how we're still seeing the metric from that branch ping, this adds a log with more specific data (like project id) than what we can gather in DataDog.

(The extra weird thing is, DataDog says the upgrades are upgrades from the legacy config, and yet no no new transition periods have started, which they should have if the existing config is a valid one. Very mysterious.)

This comment was marked as outdated.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 13, 2025
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #93572   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files       10322    10322           
  Lines      595060   595062    +2     
  Branches    23141    23141           
=======================================
+ Hits       523689   523693    +4     
+ Misses      70878    70876    -2     
  Partials      493      493           

@lobsterkatie lobsterkatie marked this pull request as ready for review June 14, 2025 03:08
@lobsterkatie lobsterkatie requested a review from a team as a code owner June 14, 2025 03:08
@lobsterkatie lobsterkatie merged commit e64a449 into master Jun 16, 2025
65 checks passed
@lobsterkatie lobsterkatie deleted the kmclb-log-when-project-grouping-config-is-updated branch June 16, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants