chore(aci milestone 3): migrate remaining anomaly detection alerts #93574
+1,096
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mifu67
commented
Jun 13, 2025
Comment on lines
+731
to
+737
| alert_rules = AlertRule.objects_with_snapshots.filter( | ||
| status__in=[ | ||
| AlertRuleStatus.PENDING.value, | ||
| AlertRuleStatus.NOT_ENOUGH_DATA.value, | ||
| ], | ||
| detection_type="dynamic", | ||
| ).filter(~Exists(AlertRuleDetector.objects.filter(alert_rule_id=OuterRef("id")))) |
There was a problem hiding this comment.
Main change is here—fetching the anomaly detection alerts that were not migrated.
mifu67
commented
Jun 13, 2025
| AlertRuleTriggerActionType.SLACK.value: "Slack", | ||
| AlertRuleTriggerActionType.MSTEAMS.value: "Microsoft Teams", | ||
| AlertRuleTriggerActionType.OPSGENIE.value: "Opsgenie", | ||
| AlertRuleTriggerActionType.DISCORD.value: "Discord", |
|
This PR has a migration; here is the generated SQL for for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
mifu67
commented
Jun 13, 2025
Comment on lines
+441
to
+442
| else: | ||
| return "Email [removed]" |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93574 +/- ##
===========================================
+ Coverage 46.30% 88.00% +41.69%
===========================================
Files 10306 10324 +18
Lines 594236 595501 +1265
Branches 23141 23141
===========================================
+ Hits 275175 524079 +248904
+ Misses 318568 70929 -247639
Partials 493 493 |
ceorourke
reviewed
Jun 13, 2025
| condition_result=DetectorPriorityLevel.OK, | ||
| ).exists() | ||
|
|
||
| def test_simple_trigger_action(self): |
There was a problem hiding this comment.
Is there a test case that replicates the situation the remaining alerts are in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the alerts that didn't get correctly migrated the first run (due to errors with discord actions or the migration stalling).