feat(aci): Edit detector form #93579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note for monday: might need to get the existing ids to update the detector?
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
# Conflicts: # static/app/views/detectors/components/forms/metricFormData.tsx # static/app/views/detectors/edit.tsx # static/app/views/detectors/new-settings.tsx
scttcper
changed the title
scttcper
commented
Jun 16, 2025
| @@ -61,7 +61,7 @@ export interface MetricDetectorFormData | |||
| MetricDetectorDynamicFormData { | |||
| aggregate: string; | |||
| environment: string; | |||
| kind: 'threshold' | 'change' | 'dynamic'; | |||
| kind: 'static' | 'percent' | 'dynamic'; | |||
There was a problem hiding this comment.
these are more in line with the values the backend is using
malwilley
approved these changes
Jun 16, 2025
|
|
||
| // Extract aggregate and visualize from the aggregate string | ||
| // Format is typically "count(transaction.duration)" | ||
| const aggregateMatch = snubaQuery?.aggregate?.match(/^(\w+)\(([^)]+)\)$/); |
There was a problem hiding this comment.
Will this always work? What are the other possible values?
I wonder if we should be using a parser for this or returning as an object form the backend? Work for later though
There was a problem hiding this comment.
yeah let me dig up what we do in other places
| const {mutateAsync: updateDetector} = useUpdateDetector(); | ||
|
|
||
| const handleSubmit = useCallback<OnSubmitCallback>( | ||
| async (data, _, __, ___, formModel) => { |
There was a problem hiding this comment.
gotta love functions with 5 arguments
| ...getNewMetricDetectorData(data as MetricDetectorFormData), | ||
| }; | ||
|
|
||
| const updatedDetector = await updateDetector(updatedData); |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building off the work in #93380 this pr adds the ability to edit a dector.