-
-
Notifications
You must be signed in to change notification settings - Fork 115
python-pytz: Update to v2025.2 #7068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
**Summary** - Brings the latest IANA 2025b timezone definitions
| install : | | ||
| %python3_install | ||
| rm -rf $installdir/usr/lib/python%python3_version%/site-packages/pytz/zoneinfo | ||
| check : | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the test? If we can run test, it would be prefered. But if it cannot run, better comment the test out and add the comment why it doesn't run. Rather than outright removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added it in the PR. Removed tests as they failed on both current and new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. So, this used to work. Failed test is probably related to this bug. There is diverged in data between pytz and tzdata package. I would prefer if you add this patch instead of removing the test. Please try adding that patch and running the test again. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails with that patch as well.
|
I don't see any changes you made. Forgot to push? |
I made no changes, answered your question, the info is in the PR. 👍 |
Summary
Test Plan
Checklist
Packaging notes