-
Notifications
You must be signed in to change notification settings - Fork 934
Allow SOPS to use custom AWS KMS and STS Endpoint #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I can't really comment on the AWS specific things, but as a general note, it looks like you should use gofmt to reformat the changes you made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is automatically generated, you should not manually modify it, but instead modify the protobuf definition and re-generate it. Right now protobuf regeneration doesn't work (see #1576) though, but I hope that will get fixed soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review, I've modify the protobuf definition and re-generate it
I use #1688 makefile but I won't include it on this PR as it's already covered in another PR
Thanks for the note, I've ran |
I apologize forgot to run the test after merging with main, I've fix the protobuf and finish test it in my local @felixfontein |
7bc71e5
to
70eba1e
Compare
You have quite a few commits in this PR that do not belong there. Could you please rebase your PR (instead of adding more merge commits) to get rid of the superfluous commits? Thanks. |
Signed-off-by: Ananda Vijaya <[email protected]>
There's case when I have custom endpoint for my AWS service, with this changes I could specify STS and KMS endpoint for my AWS service
Example usage: