Repository navigation
feat(web): add hide secret control - #443
Conversation
468e49a to
449b944
Compare
|
Rebased the three feature commits onto current main without conflicts. The focused VaultView suite passes 29/29 and the rebased diff is clean. TypeScript still cannot complete in this checkout because the generated |
cf3d5e0 to
eb8b070
Compare
Maxerns
left a comment
There was a problem hiding this comment.
The implementation itself looks right.
I verified it in isolation:
- full suite: 109/109 green
typecheck: clean apart from the known WASM issue- commits: signed off
I also probed the paths that aren’t currently covered by tests. Hiding a secret correctly drops a late share response, and if secret B is revealed while secret A’s share is still pending, B stays selected and the late link from A never appears. So the generation guard is doing its job. The switch to ID-based aria-current is a nice improvement too.
I’ve just got three test only asks before approving.
First, the issue specifically calls out preserving a newly selected secret when an older share completes. Right now only the hide case is pinned. Could you add the reveal B while A’s share is pending case as well? I confirmed the behaviour already works, so this is just about locking it in.
Second, keyboard activation of Hide isn’t exercised yet; all the coverage uses clicks. Swapping one of the e2e Hide clicks for an Enter keypress would cover the keyboard path the issue asks for without adding much more test code.
Third, the new secret-hiding describe block currently relies on project/org mocks set up by earlier blocks. Running it by itself with -t fails, so it needs its own beforeEach fixture setup to make the tests independent and safe to reorder.
One tiny cleanup while you’re there: there’s also a double blank line between the two funnel tests.
No production changes needed from my side once those tests are tightened up, I’m happy to approve.
Maxerns
left a comment
There was a problem hiding this comment.
oops meant to request changes
|
Added the missing stale-share regression (reveal B while A’s share is pending), changed an e2e Hide action to keyboard Enter, and made the secret-hiding unit block independent with its own mock setup. VaultView passes 30/30 and diff-check is clean. Playwright could not run locally because e2e/.fixture.json is missing; I have not claimed a browser pass. |
Signed-off-by: tayfuryldzz <yildiztayfur668@gmail.com>
Signed-off-by: tayfuryldz <yildiztayfur668@gmail.com>
Signed-off-by: tayfuryldz <yildiztayfur668@gmail.com>
Signed-off-by: tayfuryldzz <yildiztayfur668@gmail.com>
|
Rebased onto current main and resolved the VaultView overlap by keeping both the upstream secret-search state and this PR’s Hide action. The stale-share/keyboard regression coverage is preserved. Web unit tests pass 138/138 excluding wasmLoader tests that require the missing generated wasm artifact, and git diff --check is clean. The real browser fixture is still unavailable locally. |
1bc48d9 to
da2f357
Compare
|
Re-verified all three follow ups are covered now.
The full suite only shows the known |
Fixes #185.
Adds a keyboard-accessible Hide secret action that clears the revealed value and share-link UI, removes aria-current from the secret, and returns focus to its list button. Reveal generations also prevent a pending share response from restoring a dismissed or superseded secret.
Validation: