Skip to content

feat(cli): add --json to org members - #546

Merged
Maxerns merged 2 commits into
getsotto:mainfrom
MayurK-cmd:org-members-json
Oct 14, 2026
Merged

Maxerns merged 2 commits into
getsotto:mainfrom
MayurK-cmd:org-members-json

Conversation

@MayurK-cmd

Copy link
Copy Markdown
Contributor

Closes #529

Signed-off-by: MayurK-cmd <mayurgk2006@gmail.com>

@Maxerns Maxerns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this matches #529 well.

The JSON output has exactly the fields the issue asks for: user_id, role, and has_keys, with the actual key material never serialized. Empty membership correctly returns [], the default human-readable output is unchanged, and the escaping case is covered too.

I also forced has_keys to always return true as a mutation check, and exactly the serializer test failed, so the coverage is protecting the real mapping rather than just the output shape.

I ran the focused tests, the full binary suite, fmt, and clippy locally, all green.

Signed-off-by: Maxerns <maksafk@gmail.com>
@Maxerns

Maxerns commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Resolved the merge conflict with main it was just the two test-import lines colliding with #589's additions, so I merged main in and kept both import sets. Full bin suite (36 tests), clippy and fmt all pass on the merged tree. Over to CI now.

@Maxerns
Maxerns merged commit dd6623d into getsotto:main Oct 14, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: add JSON output to organisation member listings

2 participants